SH, my initial comment is "So what!" In the first place, I personally don't think anyone can make a valid ranking of a POTUS until about 30 years after he leaves office - it takes time to see how his policies develop and influence the direction of the country. In the second place, the historians have their criteria for effectiveness and I have mine - and the criteria are not the same. And in the third place, most of these "historians" tend to be from academia, and their left bias is well known.
And I still think DJT will not be the candidate in 2024 - he may be the kingmaker for the GOP, wielding considerable influence in selecting the nominee.